From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757065Ab2CENFu (ORCPT ); Mon, 5 Mar 2012 08:05:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47897 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757024Ab2CENFt (ORCPT ); Mon, 5 Mar 2012 08:05:49 -0500 Date: Mon, 5 Mar 2012 14:05:48 +0100 (CET) From: Jiri Kosina To: Rajiv Andrade Cc: Stefan Berger , linux-kernel@vger.kernel.org, Andrew Morton , tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH] tpm_tis: fix tis_lock with respect to RCU In-Reply-To: <20120305125309.GA2923@hardened-box.ibm.com> Message-ID: References: <20120305125309.GA2923@hardened-box.ibm.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Mar 2012, Rajiv Andrade wrote: > > cleanup_tis() -> tpm_remove_hardware() -> syncrhonize_rcu() is being > > called in an atomic context (tis_lock spinlock held), which is not > > allowed. Convert tis_lock to mutex. > > > > Signed-off-by: Jiri Kosina > > Acked-by: Rajiv Andrade Okay, thanks. I am taking this through trivial.git then. -- Jiri Kosina SUSE Labs