From: Jiri Kosina <jkosina@suse.cz>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: HID: picoLCD: optimize for inactive debugfs
Date: Mon, 1 Oct 2012 10:25:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1210011025490.27440@pobox.suse.cz> (raw)
In-Reply-To: <20120930220419.01408e0e@neptune.home>
On Sun, 30 Sep 2012, Bruno Prémont wrote:
> Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when
> there is an active listener on debugfs for events.
>
> His change got lost while splitting hid_picolcd.c, restore it.
>
> Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
> ---
>
>
> diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
> index 6ef03be..4809aa1 100644
> --- a/drivers/hid/hid-picolcd_debugfs.c
> +++ b/drivers/hid/hid-picolcd_debugfs.c
> @@ -402,7 +402,7 @@ void picolcd_debug_out_report(struct picolcd_data *data,
> #define BUFF_SZ 256
>
> /* Avoid unnecessary overhead if debugfs is disabled */
> - if (!hdev->debug_events)
> + if (list_empty(&hdev->debug_list))
> return;
>
> buff = kmalloc(BUFF_SZ, GFP_ATOMIC);
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2012-10-01 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-30 20:04 Bruno Prémont
2012-10-01 8:25 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1210011025490.27440@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=bonbons@linux-vserver.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®