From: Hugh Dickins <hughd@google.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: trace filemap add and del
Date: Tue, 20 Nov 2012 21:07:39 -0800 (PST) [thread overview]
Message-ID: <alpine.LNX.2.00.1211202103460.16323@eggly.anvils> (raw)
In-Reply-To: <1352404450-30100-1-git-send-email-robert.jarzmik@free.fr>
On Thu, 8 Nov 2012, Robert Jarzmik wrote:
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -467,6 +471,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping,
> } else {
> page->mapping = NULL;
> /* Leave page->index set: truncation relies upon it */
> + trace_mm_filemap_add_to_page_cache(page);
> spin_unlock_irq(&mapping->tree_lock);
> mem_cgroup_uncharge_cache_page(page);
> page_cache_release(page);
I doubt if you really want your tracepoint sited just in this error path.
Hugh
next prev parent reply other threads:[~2012-11-21 5:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 19:54 Robert Jarzmik
2012-11-20 23:57 ` Andrew Morton
2012-11-21 3:59 ` Dave Chinner
2012-11-21 10:38 ` Robert Jarzmik
2012-11-22 11:51 ` Robert Jarzmik
2012-11-23 0:15 ` Dave Chinner
2012-11-21 10:36 ` Robert Jarzmik
2012-11-21 5:07 ` Hugh Dickins [this message]
2012-11-21 10:41 ` Robert Jarzmik
2012-11-23 14:10 ` [PATCH v2] " Robert Jarzmik
2012-11-23 23:34 ` [PATCH v3] " Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1211202103460.16323@eggly.anvils \
--to=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®