From: Finn Thain <fthain@telegraphics.com.au>
To: Nick Krause <xerofoify@gmail.com>
Cc: sammy@sammy.net, Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k <linux-m68k@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h
Date: Fri, 4 Jul 2014 16:19:14 +1000 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1407041615280.8188@nippy.intranet> (raw)
In-Reply-To: <CAPDOMVhvuvWesMev-5dOFA78Sf67o0kUCXR2VkdhE-xeiYQ=6w@mail.gmail.com>
On Fri, 4 Jul 2014, Nick Krause wrote:
> What are these two lines for them another compile issue?
I don't see why those two lines are important.
> >> -/* FIXME - when we get this compiling */
> >> /* erm, now that it's compiling, what do we do with it? */
> >> #define _KERNPG_TABLE 0
Presumably it is the third line that the "FIXME" refers to.
I didn't write this code, but obviously it isn't supposed to be read as
/* FIXME - this comment needs to be deleted */
--
next prev parent reply other threads:[~2014-07-04 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 1:41 Nicholas Krause
2014-07-03 11:56 ` Sam Creasey
2014-07-04 1:28 ` Finn Thain
2014-07-04 6:03 ` Nick Krause
2014-07-04 6:19 ` Finn Thain [this message]
2014-07-04 16:10 ` Nick Krause
2014-07-04 16:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1407041615280.8188@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sammy@sammy.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®