From: Jiri Kosina <jkosina@suse.cz>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
David Herrmann <dh.herrmann@googlemail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: uHID: fix excepted report type
Date: Wed, 1 Oct 2014 21:01:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1410012101350.26311@pobox.suse.cz> (raw)
In-Reply-To: <CANq1E4QGPWNBSLzd3_5NJVNkCjBELREN=_twVdcdSe6efOOJ2Q@mail.gmail.com>
On Wed, 1 Oct 2014, David Herrmann wrote:
> > diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
> > index f6ec5ea..e094c57 100644
> > --- a/drivers/hid/uhid.c
> > +++ b/drivers/hid/uhid.c
> > @@ -154,7 +154,7 @@ static int __uhid_report_queue_and_wait(struct uhid_device *uhid,
> >
> > spin_lock_irqsave(&uhid->qlock, flags);
> > *report_id = ++uhid->report_id;
> > - uhid->report_type = ev->type;
> > + uhid->report_type = ev->type + 1;
>
> Nice catch. We always need the *_REPLY type as response:
>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2014-10-01 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:59 Benjamin Tissoires
2014-10-01 16:36 ` David Herrmann
2014-10-01 19:01 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1410012101350.26311@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=dh.herrmann@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®