From: Jiri Kosina <jkosina@suse.cz>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Ping Cheng <pinglinux@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jason Gerecke <killertofu@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: wacom: do not directly use input_mt_report_pointer_emulation
Date: Wed, 18 Feb 2015 23:43:52 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1502182343360.28769@pobox.suse.cz> (raw)
In-Reply-To: <CAN+gG=GWAVKrbaC_Ww7DXWuJ8VkHEqO4GbrygGP6Xpb9FZ897w@mail.gmail.com>
On Tue, 17 Feb 2015, Benjamin Tissoires wrote:
> On Tue, Feb 17, 2015 at 5:36 PM, Ping Cheng <pinglinux@gmail.com> wrote:
> > On Tue, Feb 17, 2015 at 11:19 AM, Benjamin Tissoires
> > <benjamin.tissoires@redhat.com> wrote:
> >> input_mt_sync_frame() calls input_mt_report_pointer_emulation() and do
> >> some internal steps required to keep in sync the state of the touch within
> >> the various reports.
> >>
> >> Given that we use input_mt_assign_slot() in this driver, it is better to
> >> use input_mt_sync_frame().
> >
> > It is sensible to me, except I think you meant input_mt_slot() instead
> > of input_mt_assign_slot().
>
> Hehe, I should have actually checked the call. I meant
> input_mt_get_slot_by_key().
>
> >
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > Reviewed-by: Ping Cheng <pingc@wacom.com>
Applied (with adjusted changelog).
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2015-02-18 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 19:19 Benjamin Tissoires
2015-02-17 22:36 ` Ping Cheng
2015-02-17 22:50 ` Benjamin Tissoires
2015-02-18 22:43 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1502182343360.28769@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®