From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757239AbbCPRXk (ORCPT ); Mon, 16 Mar 2015 13:23:40 -0400 Received: from mga01.intel.com ([192.55.52.88]:32210 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbbCPRXh (ORCPT ); Mon, 16 Mar 2015 13:23:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,410,1422950400"; d="scan'208";a="541649771" Date: Mon, 16 Mar 2015 17:22:24 +0000 (UTC) From: Keith Busch X-X-Sender: vmware@localhost.lm.intel.com To: Alexey Khoroshilov cc: Matthew Wilcox , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] NVMe: Fix error handling of class_create("nvme") In-Reply-To: <1425681821-620-1-git-send-email-khoroshilov@ispras.ru> Message-ID: References: <1425681821-620-1-git-send-email-khoroshilov@ispras.ru> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2015, Alexey Khoroshilov wrote: > class_create() returns ERR_PTR on failure, > so IS_ERR() should be used instead of check for NULL. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Thanks for the fix. Acked-by: Keith Busch