From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbbHQIFZ (ORCPT ); Mon, 17 Aug 2015 04:05:25 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:39951 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbbHQIFW (ORCPT ); Mon, 17 Aug 2015 04:05:22 -0400 Date: Mon, 17 Aug 2015 18:04:59 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: linux-kernel , linux-m68k , linuxppc-dev Subject: Re: [RFC v5 00/26] Re-use nvram module In-Reply-To: Message-ID: References: <20150725074559.543547894@telegraphics.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Aug 2015, Geert Uytterhoeven wrote: > Hi Finn, > > On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain > wrote: > > The generic NVRAM module, drivers/char/generic_nvram, implements a > > /dev/nvram misc device. It is used only by 32-bit PowerPC platforms > > and isn't generic enough to be more widely used. > > [...] > > Thanks! > > You can add my > Acked-by: Geert Uytterhoeven > to patches 03, 04, 11, 19, 23, 24, 25, 26. Thanks for reviewing. > > BTW, checkpatch reported a few newly-introduced whitespace errors in > patches 03, 05, 16, 24, and 25. I will check again, but I'm sure those are all deliberate. I examined all the "errors" and "warnings" before submitting. checkpatch doesn't really understand the difference between whitespace used for indentation of statements (according to scope) and whitespace used for alignment of terms or parameters (when line-wrapped). Any tool that fails to make that distinction can't be depended upon to correctly validate the elisp in Documentation/CodingStyle, for example. -- > > Gr{oetje,eeting}s, > > Geert >