From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754491AbbHQIsi (ORCPT ); Mon, 17 Aug 2015 04:48:38 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:40250 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbbHQIsg (ORCPT ); Mon, 17 Aug 2015 04:48:36 -0400 Date: Mon, 17 Aug 2015 18:48:11 +1000 (AEST) From: Finn Thain To: Geert Uytterhoeven cc: linux-kernel , linux-m68k , linuxppc-dev Subject: Re: [RFC v5 00/26] Re-use nvram module In-Reply-To: Message-ID: References: <20150725074559.543547894@telegraphics.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Aug 2015, Geert Uytterhoeven wrote: > On Mon, Aug 17, 2015 at 10:04 AM, Finn Thain > wrote: > >> BTW, checkpatch reported a few newly-introduced whitespace errors in > >> patches 03, 05, 16, 24, and 25. > > > > I will check again, but I'm sure those are all deliberate. I examined > > all the "errors" and "warnings" before submitting. > > > > checkpatch doesn't really understand the difference between whitespace > > used for indentation of statements (according to scope) and whitespace > > used for alignment of terms or parameters (when line-wrapped). Any > > tool that fails to make that distinction can't be depended upon to > > correctly validate the elisp in Documentation/CodingStyle, for > > example. > > Checkpatch complains because you don't replace a sequence of 8 spaces by > a TAB in continuation lines. Right. Were such a sequence used for indentation, a tab should be used instead. After those tabs, spaces are needed for alignment (see elisp example mentioned above). But I sure wouldn't want to try to encode that distinction in regexp (as opposed to comparing a patch with its pretty-printed version, as might be generated by an actual C parser). So I expect some false positives from checkpatch. -- > > Gr{oetje,eeting}s, > > Geert