From: Finn Thain <fthain@telegraphics.com.au>
To: Rudhresh <rudhresh.jk@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI: dtc: Fixed a brace issue on return 0
Date: Tue, 25 Aug 2015 11:54:55 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1508241649310.19365@nippy.intranet> (raw)
In-Reply-To: <1435491896-9755-1-git-send-email-rudhresh.jk@gmail.com>
On Sun, 28 Jun 2015, Rudhresh wrote:
> From: rudhresh <rudhresh.jk@gmail.com>
>
> Return is not a function so parenthesis is not required
>
> Signed-off-by: Rudhresh <rudhresh.jk@gmail.com>
Can you put your full name here?
You must address your patches to all of the interested parties (see
scripts/get_maintainer.pl).
Please read Documentation/SubmittingPatches and adhere to the instructions
therein.
--
>
> ---
> drivers/scsi/dtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..c793ecf 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -363,7 +363,7 @@ static inline int NCR5380_pread(struct Scsi_Host *instance, unsigned char *dst,
> NCR5380_read(RESET_PARITY_INTERRUPT_REG);
> if (i > hostdata->spin_max_r)
> hostdata->spin_max_r = i;
> - return (0);
> + return 0;
> }
>
> /****************************************************************
> @@ -417,7 +417,7 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src,
> rtrc(0);
> if (i > hostdata->spin_max_w)
> hostdata->spin_max_w = i;
> - return (0);
> + return 0;
> }
>
> MODULE_LICENSE("GPL");
>
prev parent reply other threads:[~2015-08-25 1:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 11:44 Rudhresh
2015-08-25 1:54 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1508241649310.19365@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rudhresh.jk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®