From: Finn Thain <fthain@telegraphics.com.au>
To: Rudhresh Kumar J <rudhreshj@cdac.in>
Cc: schmitzmic@gmail.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI: DTC: Removed 0 initialization for statics
Date: Tue, 25 Aug 2015 11:54:26 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1508251153090.5160@nippy.intranet> (raw)
In-Reply-To: <1435517285-13411-1-git-send-email-rudhresh.jk@gmail.com>
On Mon, 29 Jun 2015, Rudhresh wrote:
> Removed unneccessary initialization of zero to a static variable
>
> Signed-off-by: Rudhresh Kumar J <rudhreshj@cdac.in>
> ---
> drivers/scsi/dtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..99164d6 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -150,7 +150,7 @@ static const struct signature {
>
> static int __init dtc_setup(char *str)
> {
> - static int commandline_current = 0;
> + static int commandline_current;
> int i;
> int ints[10];
>
> @@ -188,7 +188,7 @@ __setup("dtc=", dtc_setup);
>
> static int __init dtc_detect(struct scsi_host_template * tpnt)
> {
> - static int current_override = 0, current_base = 0;
> + static int current_override, current_base;
> struct Scsi_Host *instance;
> unsigned int addr;
> void __iomem *base;
>
This issue affects all four copies of this code in the NCR5380 drivers:
drivers/scsi/t128.c: static int commandline_current = 0;
drivers/scsi/t128.c: static int current_override = 0, current_base = 0;
drivers/scsi/dtc.c: static int commandline_current = 0;
drivers/scsi/dtc.c: static int current_override = 0, current_base = 0;
drivers/scsi/g_NCR5380.c: static int commandline_current = 0;
drivers/scsi/g_NCR5380.c: static int current_override = 0;
drivers/scsi/pas16.c: static int commandline_current = 0;
drivers/scsi/pas16.c: static int current_override = 0;
drivers/scsi/pas16.c: static unsigned short current_base = 0;
And there are more instances of redundant initialization in pas16.c,
NCR5380.c and sun3_scsi.c.
All of these drivers have the same maintainers, so I'd prefer a single
patch to fix this.
You must address your patches to all of the interested parties (see
scripts/get_maintainer.pl).
--
prev parent reply other threads:[~2015-08-25 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 18:48 Rudhresh
2015-08-25 1:54 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1508251153090.5160@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rudhreshj@cdac.in \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®