From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <keith.busch@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, linux-pci@vger.kernel.org,
Jiang Liu <jiang.liu@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Bryan Veal <bryan.e.veal@intel.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [RFC PATCHv2] x86/pci: Initial commit for new VMD device driver
Date: Mon, 12 Oct 2015 21:05:46 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1510122050180.27742@localhost.lm.intel.com> (raw)
In-Reply-To: <20151006231412.GF29420@localhost>
On Tue, 6 Oct 2015, Bjorn Helgaas wrote:
>> +static int __init vmd_init(void)
>> +{
>> + return pci_register_driver(&vmd_drv);
>> +}
>> +module_init(vmd_init);
>
> module_pci_driver(vmd_drv)?
We actually only have a module_init in this driver, and purposely left
out module_exit. We don't want to be able to unload this because we
can't reference count this module for modules depending on it.
'rmmod <module>' returns busy if you're actively using a device that
module is driving, but the end devices VMD provides are not driven by the
VMD driver; it'd be kind of like being able to unload the pci core driver.
prev parent reply other threads:[~2015-10-12 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 17:44 Keith Busch
2015-10-03 9:45 ` Ingo Molnar
2015-10-05 14:34 ` Keith Busch
2015-10-05 16:46 ` Ingo Molnar
2015-10-05 18:03 ` Keith Busch
2015-10-04 0:29 ` kbuild test robot
2015-10-06 23:14 ` Bjorn Helgaas
2015-10-07 0:21 ` Keith Busch
2015-10-07 16:04 ` Keith Busch
2015-10-08 13:29 ` Bjorn Helgaas
2015-10-08 13:47 ` Bjorn Helgaas
2015-10-12 21:05 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1510122050180.27742@localhost.lm.intel.com \
--to=keith.busch@intel.com \
--cc=bhelgaas@google.com \
--cc=bryan.e.veal@intel.com \
--cc=dan.j.williams@intel.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®