From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965034AbbLHOQL (ORCPT ); Tue, 8 Dec 2015 09:16:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:59272 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964831AbbLHOQI (ORCPT ); Tue, 8 Dec 2015 09:16:08 -0500 Date: Tue, 8 Dec 2015 15:16:05 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Rasmus Villemoes cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] floppy: make local variable non-static In-Reply-To: <1448981641-17485-1-git-send-email-linux@rasmusvillemoes.dk> Message-ID: References: <1448981641-17485-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Dec 2015, Rasmus Villemoes wrote: > There's no reason for temparea to be static, since it's only used for > temporary sprintf output. It's not immediately obvious that the output > will always fit (in the worst case, the output including '\0' is > exactly 32 bytes), so save a future reader from worrying about that. > > Signed-off-by: Rasmus Villemoes Applied, thanks. (I have applied this to trivial.git, as was too lazy to revive floppy tree just for this :) ). -- Jiri Kosina SUSE Labs