From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756703AbcARWLK (ORCPT ); Mon, 18 Jan 2016 17:11:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:32903 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754871AbcARWLI (ORCPT ); Mon, 18 Jan 2016 17:11:08 -0500 Date: Mon, 18 Jan 2016 23:11:07 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Lauri Kasanen , linux-input@vger.kernel.org, Max Fedotov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: sony: do not bail out when the sixaxis refuses the output report In-Reply-To: <1452272329-8744-1-git-send-email-benjamin.tissoires@redhat.com> Message-ID: References: <1452272329-8744-1-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jan 2016, Benjamin Tissoires wrote: > When setting the operational mode, some third party (Speedlink Strike-FX) > gamepads refuse the output report. Failing here means we refuse to > initialize the gamepad while this should be harmless. > > The weird part is that the initial commit that added this: a7de9b8 > ("HID: sony: Enable Gasia third-party PS3 controllers") mentions this > very same controller as one requiring this output report. > Anyway, it's broken for one user at least, so let's change it. > We will report an error, but at least the controller should work. > > And no, these devices present themselves as legacy Sony controllers > (VID:PID of 054C:0268, as in the official ones) so there are no ways > of discriminating them from the official ones. > > https://bugzilla.redhat.com/show_bug.cgi?id=1255325 > > Reported-and-tested-by: Max Fedotov > Signed-off-by: Benjamin Tissoires Applied, thanks. -- Jiri Kosina SUSE Labs