From: Jiri Kosina <jikos@kernel.org>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Rodrigo Gomes <rodrigo.toste.gomes@gmail.com>
Subject: Re: [PATCH] HID: rmi: Check that the device is a RMI device in suspend and resume callbacks
Date: Wed, 27 Jan 2016 22:41:48 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1601272241250.21446@cbobk.fhfr.pm> (raw)
In-Reply-To: <1453851636-5490-1-git-send-email-aduggan@synaptics.com>
On Tue, 26 Jan 2016, Andrew Duggan wrote:
> Commit 092563604217 ("HID: rmi: Disable scanning if the device is not a
> wake source") introduced a regression for devices which use hid-rmi to
> handle composite USB devices. The suspend or resume callbacks are not
> checking that the device is a RMI device before calling rmi_read or
> rmi_write. This results in dereferencing uninitialized variables on
> non RMI devices. This patch checks that the RMI_DEVICE flag is set before
> sending RMI commands to the device.
>
> Reported-by: Rodrigo Gomes <rodrigo.toste.gomes@gmail.com>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
Applied to for-4.5/upstream-fixes.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2016-01-27 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 23:40 Andrew Duggan
2016-01-27 21:41 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1601272241250.21446@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.toste.gomes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®