From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbcBPKFt (ORCPT ); Tue, 16 Feb 2016 05:05:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:55534 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754412AbcBPKFr (ORCPT ); Tue, 16 Feb 2016 05:05:47 -0500 Date: Tue, 16 Feb 2016 11:05:45 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: fix hid_ignore_special_drivers module parameter In-Reply-To: <1455293437-12088-1-git-send-email-benjamin.tissoires@redhat.com> Message-ID: References: <1455293437-12088-1-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Feb 2016, Benjamin Tissoires wrote: > hid_ignore_special_drivers works fine until hid_scan_report > autodetects and reassign devices (for hid-multitouch, > hid-microsoft and hid-rmi). > > Simplify the handling of the parameter: if it is there, use > hid-generic, no matter what, and if not, scan the device or > rely on the hid_have_special_driver table. > > This was detected while trying to disable hid-multitouch on > a Surface Pro cover which prevented to use the keyboard. > > Signed-off-by: Benjamin Tissoires > CC: stable@vger.kernel.org > --- > > Hi Jiri, > > not sure if we should keep or not the stable@ tag. The issue was there for a > long time, and nobody complained. It's up to you. I've now applied it to for-4.5/upstream-fixes, but will wait if there is any other more important fix that'd trigger the push of this branch to Linus; otherwise it'll go in the merge window pile and will get backported to -stable later. Thanks, -- Jiri Kosina SUSE Labs