From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbcFULJ0 (ORCPT ); Tue, 21 Jun 2016 07:09:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:39234 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbcFULJX (ORCPT ); Tue, 21 Jun 2016 07:09:23 -0400 Date: Tue, 21 Jun 2016 13:09:19 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Guohua Zhong cc: Benjamin Tissoires , Mika Westerberg , Dmitry Torokhov , Benson Leung , Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown In-Reply-To: <1466504865-19907-1-git-send-email-ghzhong@yifangdigital.com> Message-ID: References: <1466504865-19907-1-git-send-email-ghzhong@yifangdigital.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Guohua Zhong wrote: > Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free > irq before device shutdown. > > Some HW design (i.e. Umaro, a chromebook model) is that the power to > i2c hid device won't down after device shutdown. Also the i2c-hid driver > do not send suspend cmd to the hid i2c device and free its irq before > shutdown.So if We touch the touchscreen or some other i2c hid device, > the power consumtion will be go up even when the device is in shutdown > state. > > Though the root cause maybe a HW issue. But it seems that it is a > good pratice to set power sleep for i2c-hid device before shutdown. Applied, thanks. -- Jiri Kosina SUSE Labs