From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030340AbcGGIa1 (ORCPT ); Thu, 7 Jul 2016 04:30:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:57798 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030305AbcGGIaX (ORCPT ); Thu, 7 Jul 2016 04:30:23 -0400 Date: Thu, 7 Jul 2016 10:30:20 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Konstantin Khlebnikov cc: Andrew Morton , linux-kernel@vger.kernel.org, Ulrich Obergfell , Aaron Tomlin Subject: Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler In-Reply-To: <146771764784.86724.6006627197118544150.stgit@buzz> Message-ID: References: <146771764784.86724.6006627197118544150.stgit@buzz> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jul 2016, Konstantin Khlebnikov wrote: > NMI handler doesn't call set_irq_regs(), so get_irq_regs() returns NULL or > stale snapshot from beginning of IRQ interrupted by NMI. Registers from > argument are always here and points to interrupted instruction and state. > > Signed-off-by: Konstantin Khlebnikov > Cc: Jiri Kosina Good catch, thanks for fixing my thinko. Reviewed-by: Jiri Kosina -- Jiri Kosina SUSE Labs