From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbcHZJFw (ORCPT ); Fri, 26 Aug 2016 05:05:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:37703 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcHZJFr (ORCPT ); Fri, 26 Aug 2016 05:05:47 -0400 Date: Fri, 26 Aug 2016 11:05:44 +0200 (CEST) From: Miroslav Benes To: Josh Poimboeuf cc: Jessica Yu , Jiri Kosina , Petr Mladek , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Chunyu Hu , Rusty Russell Subject: Re: [PATCH v2] livepatch/module: make TAINT_LIVEPATCH module-specific In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Aug 2016, Josh Poimboeuf wrote: > There's no reliable way to determine which module tainted the kernel > with TAINT_LIVEPATCH. For example, /sys/module//taint > doesn't report it. Neither does the "mod -t" command in the crash tool. > > Make it crystal clear who the guilty party is by associating > TAINT_LIVEPATCH with any module which sets the "livepatch" modinfo > attribute. The flag will still get set in the kernel like before, but > now it also sets the same flag in mod->taint. > > Note that now the taint flag gets set when the module is loaded rather > than when it's enabled. > > I also renamed find_livepatch_modinfo() to check_modinfo_livepatch() to > better reflect its purpose: it's basically a livepatch-specific > sub-function of check_modinfo(). > > Reported-by: Chunyu Hu > Signed-off-by: Josh Poimboeuf Acked-by: Miroslav Benes Miroslav