From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161067AbcIZDzw (ORCPT ); Sun, 25 Sep 2016 23:55:52 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:34056 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941326AbcIZDzv (ORCPT ); Sun, 25 Sep 2016 23:55:51 -0400 Date: Mon, 26 Sep 2016 13:56:04 +1000 (AEST) From: Finn Thain To: Ondrej Zary cc: Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] g_NCR5380: Reduce overrides[] from array to struct In-Reply-To: <1474743545-4731-3-git-send-email-linux@rainbow-software.org> Message-ID: References: <1474743545-4731-1-git-send-email-linux@rainbow-software.org> <1474743545-4731-3-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Sep 2016, Ondrej Zary wrote: > Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE. Then > remove all code iterating the overrides[] array and reduce it to struct > card. There is a reference to the compile-time override in Documentation/scsi/g_NCR5380.txt which needs to be removed also. The patch looks fine aside from that. --