From: Finn Thain <fthain@telegraphics.com.au>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michael Schmitz <schmitzmic@gmail.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: NCR5380: no longer mark irq probing as __init
Date: Wed, 12 Oct 2016 10:20:33 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1610121004480.20775@nippy.intranet> (raw)
In-Reply-To: <201610112258.05050.linux@rainbow-software.org>
On Tue, 11 Oct 2016, Ondrej Zary wrote:
>
> I've tested IRQ probing on my IRQ7-hardwired ISA card without any
> success some time ago. No IRQ was detected because it wasn't even
> generated (no increment in /proc/interruptts).
The IRQ line does not appear in /proc/interrupts unless it has already
been claimed. So if you saw that the interrupt count stayed the same, then
the interrupt line wasn't available in the first place.
> It also produced some warnings in dmesg about conflicting interrupt
> flags.
Presumably that's because there is no way to probe shared interrupt lines.
> Can't the IRQ probing be simply deleted?
>
It isn't clear to me that there's a bug in the driver. I never saw a bug
in the irq probe code when I went looking for a reason to delete that code
a while ago.
Anyway, assuming that the interrupt line on your card works fine, have you
considered using probe_irq_on/probe_irq_off? See for example, sym53c416.c
and NCR53c406a.c.
Bug or no bug, I'd be very happy to delete the NCR5380 probe code if we
can use the standard probe functions to retain the documented
functionality.
--
prev parent reply other threads:[~2016-10-11 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 9:23 Arnd Bergmann
2016-10-11 9:39 ` Finn Thain
2016-10-11 20:58 ` Ondrej Zary
2016-10-11 23:20 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1610121004480.20775@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®