From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936491AbcJRWaG (ORCPT ); Tue, 18 Oct 2016 18:30:06 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:50710 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932771AbcJRW36 (ORCPT ); Tue, 18 Oct 2016 18:29:58 -0400 Date: Wed, 19 Oct 2016 09:27:34 +1100 (AEDT) From: Finn Thain To: Arnd Bergmann cc: "James E.J. Bottomley" , "Martin K. Petersen" , Ondrej Zary , Hannes Reinecke , Hannes Reinicke , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency In-Reply-To: <20161018151827.2729976-1-arnd@arndb.de> Message-ID: References: <20161018151827.2729976-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Oct 2016, Arnd Bergmann wrote: > The driver was changed to call ioport_map, which breaks platforms that > cannot provide this function: > > drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0': > g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map' > > This adds a Kconfig dependency. > > Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers") > Signed-off-by: Arnd Bergmann Acked-by: Finn Thain > --- > drivers/scsi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index 98451fe031a4..3b416c9efe5e 100644 > --- a/drivers/scsi/Kconfig > +++ b/drivers/scsi/Kconfig > @@ -744,7 +744,7 @@ config SCSI_ISCI > > config SCSI_GENERIC_NCR5380 > tristate "Generic NCR5380/53c400 SCSI ISA card support" > - depends on ISA && SCSI > + depends on ISA && SCSI && HAS_IOPORT_MAP > select SCSI_SPI_ATTRS > ---help--- > This is a driver for old ISA card SCSI controllers based on a >