From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbcKBHs4 (ORCPT ); Wed, 2 Nov 2016 03:48:56 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:46146 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbcKBHsz (ORCPT ); Wed, 2 Nov 2016 03:48:55 -0400 Date: Wed, 2 Nov 2016 18:49:02 +1100 (AEDT) From: Finn Thain To: Ondrej Zary cc: Christoph Hellwig , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] g_NCR5380: Fix release region in error handling In-Reply-To: <1477945112-25659-7-git-send-email-linux@rainbow-software.org> Message-ID: References: <1477945112-25659-1-git-send-email-linux@rainbow-software.org> <1477945112-25659-7-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Oct 2016, Ondrej Zary wrote: > When a SW-configurable card is specified but not found, the driver > releases wrong region, causing the following message in kernel log: > Trying to free nonexistent resource <0000000000000000-000000000000000f> > > Fix it by assigning base earlier. > > Signed-off-by: Ondrej Zary This fix is not related to the others in this series. It could go at the beginning where it is easy to cherry-pick. Fixes: a8cfbcaec0c1 ("scsi: g_NCR5380: Stop using scsi_module.c") Acked-by: Finn Thain > --- > drivers/scsi/g_NCR5380.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c > index 6a08d3e..d33e71f 100644 > --- a/drivers/scsi/g_NCR5380.c > +++ b/drivers/scsi/g_NCR5380.c > @@ -258,12 +258,12 @@ static int generic_NCR5380_init_one(struct scsi_host_template *tpnt, > if (ports[i]) { > /* At this point we have our region reserved */ > magic_configure(i, 0, magic); /* no IRQ yet */ > - outb(0xc0, ports[i] + 9); > - if (inb(ports[i] + 9) != 0x80) { > + base = ports[i]; > + outb(0xc0, base + 9); > + if (inb(base + 9) != 0x80) { > ret = -ENODEV; > goto out_release; > } > - base = ports[i]; > port_idx = i; > } else > return -EINVAL; > --