From: Finn Thain <fthain@telegraphics.com.au>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: dmx3191d: use module_pci_driver
Date: Thu, 17 Nov 2016 09:56:45 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1611170954190.25297@nippy.intranet> (raw)
In-Reply-To: <015ae0a9f5aea965329a6669367ee7a61089ef6b.1479278839.git.geliangtang@gmail.com>
On Wed, 16 Nov 2016, Geliang Tang wrote:
> Use module_pci_driver() helper to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/dmx3191d.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c
> index 3aa4657..6af3394 100644
> --- a/drivers/scsi/dmx3191d.c
> +++ b/drivers/scsi/dmx3191d.c
> @@ -153,18 +153,7 @@ static struct pci_driver dmx3191d_pci_driver = {
> .remove = dmx3191d_remove_one,
> };
>
> -static int __init dmx3191d_init(void)
> -{
> - return pci_register_driver(&dmx3191d_pci_driver);
> -}
> -
> -static void __exit dmx3191d_exit(void)
> -{
> - pci_unregister_driver(&dmx3191d_pci_driver);
> -}
> -
> -module_init(dmx3191d_init);
> -module_exit(dmx3191d_exit);
> +module_pci_driver(dmx3191d_pci_driver);
>
> MODULE_AUTHOR("Massimo Piccioni <dafastidio@libero.it>");
> MODULE_DESCRIPTION("Domex DMX3191D SCSI driver");
>
next prev parent reply other threads:[~2016-11-16 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 13:00 [PATCH] [media] netup_unidvb: " Geliang Tang
2016-11-16 13:00 ` [PATCH] scsi: a100u2w: " Geliang Tang
2016-11-16 13:00 ` [PATCH] scsi: dmx3191d: " Geliang Tang
2016-11-16 22:56 ` Finn Thain [this message]
2016-11-17 1:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1611170954190.25297@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=geliangtang@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®