From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932816AbcK1Nhp (ORCPT ); Mon, 28 Nov 2016 08:37:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:38648 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932295AbcK1Nhg (ORCPT ); Mon, 28 Nov 2016 08:37:36 -0500 Date: Mon, 28 Nov 2016 14:37:34 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Benjamin Tissoires cc: Chris Chiu , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: multitouch: handle external buttons for Precision Touchpads In-Reply-To: <1480068490-32765-1-git-send-email-benjamin.tissoires@redhat.com> Message-ID: References: <1480068490-32765-1-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Nov 2016, Benjamin Tissoires wrote: > According to https://msdn.microsoft.com/en-us/library/windows/hardware/mt604195(v=vs.85).aspx > external buttons have some weird usage mapping: > - Button 2 Indicates Button State for external button for primary > (default left) clicking. > - Button 3 Indicates Button State for external button for secondary > (default right) clicking. > > So in the current state, the buttons are mapped to right and middle. > Move the usage by one to correctly map the external buttons. > > Tested-by: Chris Chiu > Signed-off-by: Benjamin Tissoires Applied to for-4.10/multitouch. Thanks, -- Jiri Kosina SUSE Labs