mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: force the IRQ level trigger only when not set
Date: Mon, 28 Nov 2016 14:43:08 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1611281442550.29400@cbobk.fhfr.pm> (raw)
In-Reply-To: <1479738087-3123-1-git-send-email-benjamin.tissoires@redhat.com>

On Mon, 21 Nov 2016, Benjamin Tissoires wrote:

> Instead of forcing the level trigger of the IRQ, we can count
> on ACPI or OF to set it up for us.
> 
> The first release of the HID over I2C specification mentioned
> that the level trigger needed to be active low. In the latest
> version of the specification, there is no such explicit mention,
> so it's better to not assume one.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> ---
> 
> changes in v2:
> - reword a little the commit message (and mention that the new spec
>   doesn't requires active low anymore)
> - add missing irq.h include as per kbuild bot raised
> 
> So after the kbuild bot warning and a search in my email folder, I realised
> that the commit message should be amended too. So here is a v2 :)

Applied to for-4.10/i2c-hid. Thanks,

-- 
Jiri Kosina
SUSE Labs

      reply	other threads:[~2016-11-28 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 14:21 Benjamin Tissoires
2016-11-28 13:43 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1611281442550.29400@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®