From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-m68k@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with via-cuda driver
Date: Tue, 3 Jan 2017 11:33:21 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.00.1701031010300.20542@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdWFaaZdKa7+T6nruEv1sB8yYAm9yZLgy-UwefxM4b8MaA@mail.gmail.com>
On Mon, 2 Jan 2017, Geert Uytterhoeven wrote:
> Hi Finn, Ben,
>
> On Sun, Jan 1, 2017 at 1:56 AM, Finn Thain <fthain@telegraphics.com.au>
> wrote:
> > Change the device probe test in the via-cuda.c driver so it will load
> > on Egret-based machines too. Remove the now redundant via-maciisi.c
> > driver.
> >
> > Tested-by: Stan Johnson <userm57@yahoo.com> Signed-off-by: Finn Thain
> > <fthain@telegraphics.com.au>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
Thanks for your review.
> I guess this will go in with the rest of the series through Ben's
> macintosh tree?
>
Most of the recent patches in drivers/macintosh, including my 2015
submission, commit 2dc710e93c ("macintosh/nvram: Remove as unused"), went
through Michael's tree. But either tree would be fine with me.
BTW, to my knowledge there is no programmer's reference material for Cuda
or Egret system controllers (excepting that which seems to be confined to
Apple Inc). AIUI, Cuda was not part of CHRP. But one could observe all of
the signalling between CPU and MCU by tracing the VIA I/O lines or doing
the equivalent in a good emulator -- theoretically, of course. Would this
be useful to reviewers?
--
> > ---
> > arch/m68k/include/asm/macintosh.h | 2 +-
> > arch/m68k/mac/config.c | 18 +-
> > arch/m68k/mac/misc.c | 72 +---
> > drivers/macintosh/Kconfig | 24 +-
> > drivers/macintosh/Makefile | 1 -
> > drivers/macintosh/adb.c | 4 -
> > drivers/macintosh/via-cuda.c | 8 +-
> > drivers/macintosh/via-maciisi.c | 677 --------------------------------------
> > 8 files changed, 30 insertions(+), 776 deletions(-)
> > delete mode 100644 drivers/macintosh/via-maciisi.c
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2017-01-03 0:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:56 [PATCH RESEND 00/10] Replace via-maciisi " Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 02/10] via-cuda: Remove redundant temporary variable Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 06/10] via-cuda: Avoid TREQ race condition Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 01/10] via-cuda: Cleanup printk calls Finn Thain
2017-02-09 13:17 ` [RESEND,01/10] " Michael Ellerman
2017-01-01 0:56 ` [PATCH RESEND 04/10] via-cuda: Prevent read buffer overflow Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 03/10] via-cuda: Add TREQ, TIP and TACK signal helpers Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 05/10] via-cuda: Fix re-initialization of reply_ptr and reading_reply Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 10/10] m68k/mac: Replace via-maciisi driver with via-cuda driver Finn Thain
2017-01-02 10:26 ` Geert Uytterhoeven
2017-01-03 0:33 ` Finn Thain [this message]
2017-01-01 0:56 ` [PATCH RESEND 09/10] via-cuda: Add support for Egret system controller Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 08/10] via-cuda: Initialize data_index early and increment consistently Finn Thain
2017-01-01 0:56 ` [PATCH RESEND 07/10] via-cuda: Use spinlock_irq_save/restore instead of enable/disable_irq Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1701031010300.20542@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®