Re: [PATCH 00/10] mac68k: Miscellaneous fixes, cleanup and modernization

[Finn Thain <fthain@telegraphics.com.au>]

On Sun, 16 Apr 2017, Geert Uytterhoeven wrote:

> Hi Finn,
> 
> On Sun, Apr 9, 2017 at 1:51 AM, Finn Thain <fthain@telegraphics.com.au> 
> wrote:
> > This series has various patches from several different people. Two 
> > printk modernization patches were originally from Geert Uytterhoeven 
> > and three Nubus patches were originally committed to the Linux/mac68k 
> > CVS by David Huggins-Daines.
> 
> Thanks, most of them look sane enough to apply and still queue for 
> v4.12.
> 
> I'm a bit reluctant about the nubus changes (patches 6 and 8), though. 
> Do you think they need more testing?
> 
> Thanks!

Patch 6 is partly dead code removal. In principle, this patch is a 
reversion to the old code (pre-v2.3.17). The old code was thoroughly 
tested in Debian Sarge. I suppose a reviewer might wonder whether we want 
to keep new code for probing fake slot resources in Apple's on-board ROMs. 
That would be useful if it could eliminate the macintosh_config struct. 
But it can't, and we don't want both mechanisms. Hence the reversion in 
the mac68k CVS.

Patch 8 changes the pointer validation code and although this has been 
tested on the valid path, you are right that it could use some negative 
testing. But that would seem to require cards with flawed ROMs. I don't 
know of any of such cards. So I think that all we can do is more review.

Maybe Michael or Laurent would be willing to review these two patches?

-- 

> 
> > Finn Thain (10):
> >   m68k/mac: IOP - Modernize printing of kernel messages
> >   m68k/mac: Modernize printing of kernel messages
> >   m68k/mac: Adopt platform_device_register_simple()
> >   m68k/mac: Clarify IOP message alloc/free confusion
> >   nubus: Fix nubus_rewinddir (from mac68k CVS)
> >   nubus: Remove slot zero probe (from mac68k CVS)
> >   nubus: Clean up printk calls (from mac68k CVS)
> >   nubus: Fix pointer validation
> >   nubus: Clean up whitespace
> >   nubus: Add MVC and VSC video card definitions
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>