From: Finn Thain <fthain@telegraphics.com.au>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: schmitzmic@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: ncr5380: constify pnp_device_id
Date: Wed, 16 Aug 2017 17:17:43 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1708161713450.976@nippy.intranet> (raw)
In-Reply-To: <1125161eb43bc7ee7f748a040ab06b40cc1537dd.1502859040.git.arvind.yadav.cs@gmail.com>
On Wed, 16 Aug 2017, Arvind Yadav wrote:
> pnp_device_id are not supposed to change at runtime. All functions
> working with pnp_device_id provided by <linux/pnp.h> work with
> const pnp_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/g_NCR5380.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
> index c34fc91..1968d81 100644
> --- a/drivers/scsi/g_NCR5380.c
> +++ b/drivers/scsi/g_NCR5380.c
> @@ -703,7 +703,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
> };
>
> #ifdef CONFIG_PNP
> -static struct pnp_device_id generic_NCR5380_pnp_ids[] = {
> +static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
> { .id = "DTC436e", .driver_data = BOARD_DTC3181E },
> { .id = "" }
> };
>
next prev parent reply other threads:[~2017-08-16 7:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 4:54 [PATCH] PNP: ide: " Arvind Yadav
2017-08-16 4:55 ` [PATCH] net: 3c509: " Arvind Yadav
2017-08-16 18:26 ` David Miller
2017-08-16 4:57 ` [PATCH] watchdog: sc1200: " Arvind Yadav
2017-08-30 3:22 ` Guenter Roeck
2017-08-16 4:58 ` [PATCH] scsi: ncr5380: " Arvind Yadav
2017-08-16 7:17 ` Finn Thain [this message]
2017-08-17 0:54 ` Martin K. Petersen
2017-08-16 4:59 ` [PATCH] scsi: aha1542: " Arvind Yadav
2017-08-16 18:10 ` [PATCH] PNP: ide: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1708161713450.976@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=arvind.yadav.cs@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®