From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbdKLDwQ (ORCPT ); Sat, 11 Nov 2017 22:52:16 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:57968 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdKLDwO (ORCPT ); Sat, 11 Nov 2017 22:52:14 -0500 Date: Sun, 12 Nov 2017 14:52:32 +1100 (AEDT) From: Finn Thain To: Greg Kroah-Hartman cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] nubus: Add support for the driver model In-Reply-To: <20171111084653.GB6403@kroah.com> Message-ID: References: <6c64ec1ff338853f8ba34783e70896565f968854.1510377369.git.fthain@telegraphics.com.au> <20171111084553.GA6403@kroah.com> <20171111084653.GB6403@kroah.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Nov 2017, Greg Kroah-Hartman wrote: > On Sat, Nov 11, 2017 at 09:45:53AM +0100, Greg Kroah-Hartman wrote: > > > > I can't take patches without any changelog text at all, that's not > > good engineering, sorry :( > > I forgot to write it, sorry. I was going to explain the decision to leave the bus matching up to the driver. > > Please fix up and resend and I will be glad to review. > > Also, please test device removal, I don't think you did that :( > The modprobe, rmmod, modprobe sequence was tested. But I think that isn't what you meant. Are you saying there is a missing NULL check? That is, static int nubus_device_remove(struct device *dev) { struct nubus_driver *ndrv = to_nubus_driver(dev->driver); int err = -ENODEV; - if (ndrv->remove) + if (dev->driver && ndrv->remove) err = ndrv->remove(to_nubus_board(dev)); return err; } Anyway, I will revise the patch and test the unbind operation on a device not already bound. Thanks for your feedback. --