mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Engelhardt <jengelh@inai.de>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: kconfig-frontends-3.6.0-0 released
Date: Sun, 13 Jan 2013 22:09:52 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.01.1301132204090.9693@nerf07.vanv.qr> (raw)
In-Reply-To: <201301131959.15246.yann.morin.1998@free.fr>


On Sunday 2013-01-13 19:59, Yann E. MORIN wrote:
>> >printf "Running libtoolize...\n"
>> >libtoolize --copy --force
>> >printf "Running aclocal...\n"
>> >aclocal -Wall --force
>> 
>> Not again. autoreconf has existed for so long, why are people still 
>> hand-coding the boilerplate?
>
>(Note: this is my very first completely autotools-based package.)
>First, I have to admit that I looked at how other packages do it, and
>I mimicked what they do, rather than invent my own.

Ok, sensible. Yes, a lot of other packages make bad examples :(
Let's hope for them to be still alive and updated when automake 1.14
is out - it will remove and flag out some terribly old remnants.

>Second, I know of autoreconf, but it does not work for 'foreign' packages
>(ie. packages that do not have the NEWS and Changelog files, for example):
>
>[--SNIP--]
>Makefile.am: required file `./NEWS' not found                                                                                                                                                                                
>Makefile.am: required file `./ChangeLog' not found                                                                                                                                                                           
>[--SNIP--]
>
>I do not have a need for such files in this package. So, it is a 'foreign'
>package, and must be handled as such by automake.
>
>How does one autoreconf a 'foreign' package?

Surely, just that:
AM_INIT_AUTOMAKE([foreign])

>> > By default, do not build with -Wall, unless the user asks for it
>> 
>> There normally is no excuse for not using -Wall by default,
>> save for trying to compile it with msvc.
>
>Sorry, did you mean: "-Wall should be the default" ?

Indeed.

>Yes, I was thinking of building with -Wall by default once the packaging
>would be a bit more stable. Now seems like a good time to add this.

>
>> >AC_HEADER_STDC
>> >AC_HEADER_STDBOOL
>> >AC_CHECK_HEADERS([ fcntl.h limits.h locale.h ])
>> >AC_CHECK_HEADERS([ stdlib.h string.h sys/time.h unistd.h ])
>> >AC_TYPE_SIZE_T
>> >AC_FUNC_MALLOC
>> >AC_FUNC_REALLOC
>> >AC_FUNC_ALLOCA
>> >AC_CHECK_FUNCS([ bzero memmove memset ])
>> >AC_CHECK_FUNCS([ strcasecmp strchr strcspn strdup strncasecmp strpbrk strrchr
>> >strspn strtol ])
>> >AC_CHECK_FUNCS([ gettimeofday mkdir regcomp setlocale uname ])
>> 
>> All of this seems pointless because you never use the results
>> (HAVE_FCNTL_H, HAVE_LIMITS_H, etc.)
>
>Right. This is the output of autoscan.

I find that program quite useless..

>As I see it, the only action we could take is to bail out if any is missing.
>Is this what you meant?

You could do that, though I would simply direct users to read the compiler
error message. That enhances (hopefully) both their knowledge on compiling,
and reduces the walltime configure runs.

If I understood right, kconfig-frontends is supposed to run on non-Linux too,
and I have yet to see a modern platform that's missing any of the stdc
functions like malloc and strchr.

  reply	other threads:[~2013-01-13 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-06 15:55 Yann E. MORIN
2013-01-12 17:25 ` Jan Engelhardt
2013-01-13 18:59   ` Yann E. MORIN
2013-01-13 21:09     ` Jan Engelhardt [this message]
2013-01-13 21:58       ` Yann E. MORIN
2013-01-13 22:37       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.01.1301132204090.9693@nerf07.vanv.qr \
    --to=jengelh@inai.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®