mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thiago Rafel Becker <trbecker@trbecker.org>
To: zwu.kernel@gmail.com
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
	wuzhy@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com
Subject: Re: [PATCH] block: remove some unnecessary codes
Date: Wed, 9 May 2012 23:58:56 -0300 (BRT)	[thread overview]
Message-ID: <alpine.LNX.2.02.1205092358090.6376@nyarly> (raw)
In-Reply-To: <1336615995-3813-1-git-send-email-zwu.kernel@gmail.com>

You should also remove the if statement on line 511.

On Thu, 10 May 2012, zwu.kernel@gmail.com wrote:

> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  block/partition-generic.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/block/partition-generic.c b/block/partition-generic.c
> index 6df5d69..4c03880 100644
> --- a/block/partition-generic.c
> +++ b/block/partition-generic.c
> @@ -473,7 +473,6 @@ rescan:
>  	/* add partitions */
>  	for (p = 1; p < state->limit; p++) {
>  		sector_t size, from;
> -		struct partition_meta_info *info = NULL;
>
>  		size = state->parts[p].size;
>  		if (!size)
> @@ -509,7 +508,6 @@ rescan:
>  		}
>
>  		if (state->parts[p].has_info)
> -			info = &state->parts[p].info;
>  		part = add_partition(disk, p, from, size,
>  				     state->parts[p].flags,
>  				     &state->parts[p].info);
> --
> 1.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2012-05-10  3:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  2:13 zwu.kernel
2012-05-10  2:58 ` Thiago Rafel Becker [this message]
2012-05-10  3:04   ` Zhi Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.02.1205092358090.6376@nyarly \
    --to=trbecker@trbecker.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®