From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756993AbaFAL0w (ORCPT ); Sun, 1 Jun 2014 07:26:52 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:41262 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbaFAL0u (ORCPT ); Sun, 1 Jun 2014 07:26:50 -0400 From: Daniel Kamil Kozar X-Google-Original-From: Daniel Kamil Kozar Date: Sun, 1 Jun 2014 13:26:43 +0200 (CEST) X-X-Sender: daniel@Jurij To: jkosina@suse.cz cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org Subject: [PATCH] usbhid : enable NO_INIT_REPORTS quirk for Semico USB Keykoard Message-ID: User-Agent: Alpine 2.03 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device which identifies itself as a "USB Keykoard" (no typo) with VID:PID 1a2c:0023 does not seem to be handling the reports initialization very well. This results in a "usb_submit_urb(ctrl) failed: -1" message from the kernel when connected, and a delay before its initialization. This patch adds the quirk for this device, which causes the delay to disappear. Signed-off-by: Daniel Kamil Kozar --- diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/hid-ids.h linux-3.15-rc7-mine/drivers/hid/hid-ids.h --- linux-3.15-rc7/drivers/hid/hid-ids.h 2014-05-26 01:06:00.000000000 +0200 +++ linux-3.15-rc7-mine/drivers/hid/hid-ids.h 2014-06-01 12:30:45.910903449 +0200 @@ -769,6 +769,10 @@ #define USB_DEVICE_ID_SAMSUNG_IR_REMOTE 0x0001 #define USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE 0x0600 +/* China Resource Semico Co., Ltd */ +#define USB_VENDOR_ID_SEMICO 0x1a2c +#define USB_DEVICE_ID_SEMICO_USB_KEYKOARD 0x0023 + #define USB_VENDOR_ID_SENNHEISER 0x1395 #define USB_DEVICE_ID_SENNHEISER_BTD500USB 0x002c diff -uprN -X linux-3.15-rc7/Documentation/dontdiff linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c --- linux-3.15-rc7/drivers/hid/usbhid/hid-quirks.c 2014-05-26 01:06:00.000000000 +0200 +++ linux-3.15-rc7-mine/drivers/hid/usbhid/hid-quirks.c 2014-06-01 12:32:01.161744987 +0200 @@ -120,6 +120,7 @@ static const struct hid_blacklist { { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS }, + { USB_VENDOR_ID_SEMICO, USB_DEVICE_ID_SEMICO_USB_KEYKOARD, HID_QUIRK_NO_INIT_REPORTS }, { 0, 0 } }; Signed-off-by: Daniel Kamil Kozar