From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbDDTcL (ORCPT ); Sat, 4 Apr 2015 15:32:11 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:38085 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbbDDTcI (ORCPT ); Sat, 4 Apr 2015 15:32:08 -0400 Date: Sat, 4 Apr 2015 22:31:26 +0300 (EEST) From: =?ISO-8859-2?Q?Giedrius_Statkevi=E8ius?= X-X-Sender: giedrius@localhost.localdomain To: Nickolaus Woodruff cc: sudipmmukherjee@gmail.com, teddywang@siliconmotion.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm7xxfb: Fix sparse warning In-Reply-To: <20150404165120.GA3111@Caladan> Message-ID: References: <20150404165120.GA3111@Caladan> User-Agent: Alpine 2.03 (LNX 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: > This patch fixes the following sparse warning in sm7xx.h: > > drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' > was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff > --- > drivers/staging/sm7xxfb/sm7xx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h > index 7cc1896..c5d6253 100644 > --- a/drivers/staging/sm7xxfb/sm7xx.h > +++ b/drivers/staging/sm7xxfb/sm7xx.h > @@ -119,7 +119,7 @@ struct ModeInit { > /********************************************************************** > SM712 Mode table. > **********************************************************************/ > -struct ModeInit vgamode[] = { > +static struct ModeInit vgamode[] = { Someone already fixed this: https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/sm7xxfb/sm7xx.h?h=staging-testing#n122 Please work against staging-testing branch of the staging tree. Su pagarba / Regards, Giedrius