From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbdDBQfh (ORCPT ); Sun, 2 Apr 2017 12:35:37 -0400 Received: from hermes.aosc.io ([199.195.250.187]:53125 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdDBQfg (ORCPT ); Sun, 2 Apr 2017 12:35:36 -0400 Date: Mon, 3 Apr 2017 00:32:08 +0800 (CST) From: Icenowy Zheng X-X-Sender: icenowy@x220i To: Maxime Ripard cc: devicetree@vger.kernel.org, Michael Turquette , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64 SoCs In-Reply-To: <20170402160237.osgt32ugw7cz7ubg@lukather> Message-ID: References: <20170329104246.34204-1-icenowy@aosc.io> <20170402160237.osgt32ugw7cz7ubg@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2 Apr 2017, Maxime Ripard wrote: > Hi, > > On Wed, Mar 29, 2017 at 06:42:41PM +0800, Icenowy Zheng wrote: >> Allwinner SoCs after sun6i-a31 nearly all have a R_CCU in PRCM part. >> (V3s and R40 do not have it, as they have even no PRCM) >> >> This patch adds support for the ones on H3/A64. >> >> Some clock/reset values are reserved for easier extending the support to >> A31/A23, but for this I think some changes to the PRCM MFD should be made, >> see [1] (Although this is only a sketch). >> >> The r_pio device node is also added for A64, as the driver is already >> merged, and its depends (r_ccu) is now met. >> >> [1] https://github.com/wens/linux/commits/sunxi-ng-prcm > > It looks good now, thanks. > > Beside from the minor fix you've mentionned, please don't use the > defined IDs (yet) in your DT patches (3 to 5). Thanks! (I think it's the same question we meet when merging V3s patchset, right? :-) ) > > It will be a PITA to get merged otherwise. We'll fix it later. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com >