From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbdLFPCQ (ORCPT ); Wed, 6 Dec 2017 10:02:16 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:49942 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdLFPCN (ORCPT ); Wed, 6 Dec 2017 10:02:13 -0500 Date: Wed, 6 Dec 2017 16:01:55 +0100 (CET) From: Rolf Evers-Fischer X-X-Sender: rolf@5HSWXM1.fritz.box To: Joe Perches cc: Rolf Evers-Fischer , apw@canonical.com, linux-kernel@vger.kernel.org Subject: Re: Checkpatch ignores spelling error by using -f In-Reply-To: <1512571954.16419.12.camel@perches.com> Message-ID: References: <1512571954.16419.12.camel@perches.com> User-Agent: Alpine 2.20 (LNX 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Provags-ID: V03:K0:Bj5XSZ7KHtKZHK4OM5h5C1/gW8jtDiRh+KhDdeAMu+qWCT7uhMx TwXB/kYXfk1bnfICFPoLtnKmhngRb5M1rNOENreldVQt3jMc8lpGQR05HvHoFLczXgyFAmy zpiHXb6pUT5UwbYFUqVcDGNWTuZW8EItAYVz1zGSCrLe+sRkyRtKtq4dlX1PBKYN0qWV3bf 43lebn3FJU++yqGnqfObw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uYLTnL2Ee1A=:ILb8QGo34W7njsPTxzhf0a f5gTc85guCAusvsCzFUTt406uBzKSsmc9i4q327Ig2J17fLALynmYpoa9XObFdYiciMX/LT3u NPI00ksMGmtuf5WQ+RSZHY87k6FRqoRtVxhKHhAhViVLNmi+RfztmB562gMcGhVUFHtuO+lB7 n5SSFhzf+w+vtgbrxiScQNLyzB6HpcBFnpkakGBakFCxSSaOvGoNcRTbSr/9jqjuPtpluLaDn l4DHWIg9tILfAFsqnUg/vPgp1A+YloZnK90xLm59iVUwAIEB78TRzKUmioIlsLJAS6YXYIbNP LpaxRMiyQVgOHCgg9YLits4hGkAPrp3/YOf9vIQ2LBqrTNV6/w/UvM/0G0r4CF7E7FKLNW8PI HBZt+3OXT3rsZqDALKJOwWJEa0Am1BfAv1GYdO4zPMZATTH9kBa5Evwi7DQxroJTLZff4zsag H4BcE9MzGXNcDibu/Mb6EoDchzE0iEQm+K/6Ir+BNnd7KWf7Ai9KMMN5k6+SSf/78QrNp06+J NfO8L/iqXOi0Ep1vnqspJztxMqqj1HCI+lTsH2D15o04OiLycFCIoR5EflfSu88/IcRxyPZs7 ynUH3zk08KG0XKS39MnN+x3uny2h4IVJswVQW8vTOgnh6Qo6WX2/yM+Q/s4PrJcDpqytZjxni uHLl45jIFA7FBS9L5me4d1qjkKkTQfoICt3a5eySc/E81aYuO/bbrlhh/we8M7zer9Nt2HmC9 n+qkwgZxzq6Zf8qHaY4mZQvK06WGC56DFycnYqz4N5njnUILo+MrTJZCN+I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote: > > Hello, > > I've just checked the file drivers/tty/serial/8250/8250_omap.c, using > > checkpatch.pl, but I forgot the '-f' option (for file). > > > > Surprisingly the checkpatch script reported a misspelling: > > > > "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'? > > #417: > > * We enable TRIG_GRANU for RX and TX and additionaly we set" > > > > Additionally it reported that the file does not appear to be a > > unified-diff (due to my mistake). > > > > Running checkpatch again with '-f', it didn't report any problems: > > > > "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is > > ready for submission." > > > > Is this a bug in checkpatch.pl? Or is it a feature? > > feature. kinda. > > checkpatch reports spelling errors in commit messages. > > Without the -f, checkpatch is reading its input as a > commit message before expecting to find a diff/patch. > > > > Thank you very much for this explanation. Best regards, Rolf