From: Rolf Evers-Fischer <embedded24@evers-fischer.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rolf Evers-Fischer <embedded24@evers-fischer.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
Subject: Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage
Date: Thu, 22 Feb 2018 17:21:13 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.20.1802221710110.1801@5HSWXM1.fritz.box> (raw)
In-Reply-To: <CAHp75VfgqqkLq0PbC0SBMCyCLqqoNZcUW0xngjacEL0VtAskmg@mail.gmail.com>
On Wed, 21 Feb 2018, Andy Shevchenko wrote:
> > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7db512854d1
>
> First of all, this shouldn't be here.
>
Please excuse me. I know that I have to remove this, but
unfortunately I forgot to do so (here and also in the other patch).
> > Signed-off-by: Rolf Evers-Fischer <rolf.evers.fischer@aptiv.com>
> > Signed-off-by: Rolf Evers-Fischer <embedded24@evers-fischer.de>
>
> Looks like bipolar disorder?
>
You are right: One "Signed-off" should be enough.
> To the topic.
> This is a slow path and your change makes code slightly less readable
> b/c of patterns used in the kernel.
>
I see. It is probably not a good idea to free the
memory in the middle of the function.
If you don't mind, I will remove this patch and change the other
one accordingly.
With best regards,
Rolf Evers-Fischer
next prev parent reply other threads:[~2018-02-22 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 12:47 [PATCH 0/2] pci: endpoint: Fix double free in pci_epf_create() Rolf Evers-Fischer
2018-02-21 12:47 ` [PATCH 1/2] pci: endpoint: Free func_name after last usage Rolf Evers-Fischer
2018-02-21 19:00 ` Andy Shevchenko
2018-02-22 16:21 ` Rolf Evers-Fischer [this message]
2018-02-22 17:12 ` Andy Shevchenko
2018-02-22 18:19 ` Lorenzo Pieralisi
2018-02-23 6:10 ` Kishon Vijay Abraham I
2018-02-23 9:36 ` Lorenzo Pieralisi
2018-02-23 10:47 ` Kishon Vijay Abraham I
2018-02-23 17:38 ` Rolf Evers-Fischer
2018-02-23 18:30 ` Lorenzo Pieralisi
2018-02-21 12:47 ` [PATCH 2/2] pci: endpoint: Fix kernel panic after put_device() Rolf Evers-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.20.1802221710110.1801@5HSWXM1.fritz.box \
--to=embedded24@evers-fischer.de \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rolf.evers.fischer@aptiv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®