From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276AbeAHC6O (ORCPT + 1 other); Sun, 7 Jan 2018 21:58:14 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:50104 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755229AbeAHC6L (ORCPT ); Sun, 7 Jan 2018 21:58:11 -0500 Date: Mon, 8 Jan 2018 13:58:06 +1100 (AEDT) From: Finn Thain To: Geert Uytterhoeven cc: Linux/m68k , Linux Kernel Mailing List Subject: Re: [PATCH v4 00/14] Modernization and fixes for NuBus subsystem In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Sun, 7 Jan 2018, Geert Uytterhoeven wrote: > it does complain when using spaces only ("please, no spaces at the > _start_ of a line"). > Checkpatch accepts this tab: int map(struct mm_id * mm_idp, unsigned long virt, unsigned long len, int prot, int phys_fd, unsigned long long offset, int done, void **data) and this one: int unlz4(unsigned char *inbuf, long len, long (*fill)(void*, unsigned long), and this combination of tabs and spaces: void sort(void *base, size_t num, size_t size, int (*cmp_func)(const void *, const void *), We have no declarations of identifiers shorter than "map" in the kernel, as yet, as luck would have it. This would be a violation: int eq(long __and_complicated_type parameter_a, long __and_complicated_type parameter_b, Unfortunately I don't have a better style checker to offer. So I won't go on about simplistic rules or the effect of excess tabs on refactoring, readability and re-usability. Suffice it to say that there seems to be room for maintainer discretion. > Do you want to assume maintainership for nubus? > I do intend to take responsibility for any regressions so I might as well assume maintainership too. If future patches continue to go through your tree, and given there are so few committers, it's just a formality, I think. > check your TABs and spaces again > Will comply. Thanks. --