mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Fix off-by-one calendar month
Date: Thu, 26 Apr 2018 18:23:54 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LNX.2.21.1804261806450.8@nippy.intranet> (raw)
In-Reply-To: <S1753913AbeDWBDM/20180423010312Z+539@vger.kernel.org>

I just noticed that my patch overlooked m68328_hwclk(). Like the other 
platforms, this one also needs tm_mon decremented.

Geert, can you amend the commit in your tree or should I submit this 
separately?

diff --git a/arch/m68k/68000/timers.c b/arch/m68k/68000/timers.c
index 252455bce144..71ddb4c98726 100644
--- a/arch/m68k/68000/timers.c
+++ b/arch/m68k/68000/timers.c
@@ -125,7 +125,9 @@ int m68328_hwclk(int set, struct rtc_time *t)
 {
 	if (!set) {
 		long now = RTCTIME;
-		t->tm_year = t->tm_mon = t->tm_mday = 1;
+		t->tm_year = 1;
+		t->tm_mon = 0;
+		t->tm_mday = 1;
 		t->tm_hour = (now >> 24) % 24;
 		t->tm_min = (now >> 16) % 60;
 		t->tm_sec = now % 60;

-- 

       reply	other threads:[~2018-04-26  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <S1753913AbeDWBDM/20180423010312Z+539@vger.kernel.org>
2018-04-26  8:23 ` Finn Thain [this message]
2018-04-26  8:41   ` Geert Uytterhoeven
     [not found] <5add30d1.1c69fb81.b868a.84f1SMTPIN_ADDED_MISSING@mx.google.com>
2018-04-24 10:06 ` Geert Uytterhoeven
2018-04-24 10:37   ` Alexandre Belloni
2018-04-24 10:51     ` Geert Uytterhoeven
2018-04-24 11:38       ` Alexandre Belloni
2018-04-24 23:38       ` Finn Thain
2018-04-24 12:54     ` Arnd Bergmann
     [not found] <S1753929AbeDWBDQ/20180423010320Z+1320@vger.kernel.org>
2018-04-23  8:48 ` Arnd Bergmann
2018-04-23 23:39   ` Finn Thain
2018-04-24  6:54     ` Geert Uytterhoeven
2018-04-23  1:02 Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.21.1804261806450.8@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®