From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413AbeE2FiT (ORCPT ); Tue, 29 May 2018 01:38:19 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:60560 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbeE2FiR (ORCPT ); Tue, 29 May 2018 01:38:17 -0400 Date: Tue, 29 May 2018 15:38:23 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , Christoph Hellwig , Guenter Roeck , Joshua Thompson , Greg Ungerer , linux-m68k , Linux Kernel Mailing List Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet In-Reply-To: Message-ID: References: <1527378785-13326-1-git-send-email-linux@roeck-us.net> <55c1c33b-4a34-bd72-57de-577ce8d95e0b@gmail.com> <2ffd0de6-e8d6-6449-7c05-cbbfd8a99a97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 May 2018, Michael Schmitz wrote: > > > > Since an arch gets to apply limits in the dma ops it implements, why > > would arch code also have to set a limit in the form of default > > platform device masks? Powerpc seems to be the only arch that does > > this. > > One of Christoph's recent patches removed most of arches' dma ops, > replacing them by one generic implementation instead. m68k was one of > the affected arches. I concede his patch series is experimental still > and not in mainline, but may be included at some time. I found some patches here, http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-dma-noncoherent.2 Looks like m68k_dma_alloc() gets renamed arch_dma_alloc() and the generic ops don't use the dma masks. Maybe I'm looking at the wrong patches? --