From: Finn Thain <fthain@telegraphics.com.au>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ips: fix missing break in switch
Date: Wed, 17 Oct 2018 09:27:45 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1810170922480.130@nippy.intranet> (raw)
In-Reply-To: <yq1ftx5sgw1.fsf@oracle.com>
On Tue, 16 Oct 2018, Martin K. Petersen wrote:
>
> Gustavo,
>
> > Add missing break statement in order to prevent the code from falling
> > through to case TEST_UNIT_READY.
>
> Applied to 4.20/scsi-queue, thanks!
>
>
This looks wrong to me. I think you've just prevented all START STOP
commands sent to logical volumes from reaching
return ((*ha->func.issue) (ha, scb));
I think a better patch is to add a "fall though" comment not a "break"
statement. (I no longer have access to a ServeRAID board so I can't test.)
--
next prev parent reply other threads:[~2018-10-16 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:12 Gustavo A. R. Silva
2018-10-16 21:47 ` Martin K. Petersen
2018-10-16 22:27 ` Finn Thain [this message]
2018-10-17 1:19 ` Martin K. Petersen
2018-10-17 3:24 ` Finn Thain
2018-10-18 1:01 ` Martin K. Petersen
2018-10-18 2:37 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1810170922480.130@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=aacraid@microsemi.com \
--cc=gustavo@embeddedor.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®