From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Joshua Thompson <funaho@jurai.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/mac: Use '030 reset method on SE/30
Date: Sun, 23 Dec 2018 10:03:27 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1812230930430.160@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdVtbnq6-6TqhnY6EKPWuupP+tCNwFj0_tJJek9qAqEoPQ@mail.gmail.com>
On Sat, 22 Dec 2018, Geert Uytterhoeven wrote:
> > - local_irq_save(flags);
> > -
> > - rom_reset();
> > -
> > - local_irq_restore(flags);
>
> I guess you removed the call to local_irq_restore() because you never
> get there anyway?
>
If a ROM call returns, we have a real problem, because we didn't call it
in an execution environment that it is designed to be called in. Anything
could happen.
Moreover, local_irq_restore() is bogus either way, given that there's
nothing that our interrupt handlers can usefully do now.
See also commit 558d5ad276c9 ("m68k/mac: Avoid soft-lockup warning after
mach_power_off").
--
next prev parent reply other threads:[~2018-12-22 23:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 2:18 Finn Thain
2018-12-22 11:04 ` Geert Uytterhoeven
2018-12-22 23:03 ` Finn Thain [this message]
2019-01-21 9:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1812230930430.160@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=funaho@jurai.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®