From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C967CC04AB5 for ; Tue, 4 Jun 2019 00:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A785225B85 for ; Tue, 4 Jun 2019 00:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfFDAFg (ORCPT ); Mon, 3 Jun 2019 20:05:36 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:42236 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfFDAFg (ORCPT ); Mon, 3 Jun 2019 20:05:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 885D327E27; Mon, 3 Jun 2019 20:05:33 -0400 (EDT) Date: Tue, 4 Jun 2019 10:05:44 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , "James E.J. Bottomley" , "Martin K. Petersen" , scsi , Linux Kernel Mailing List , stable , linux-m68k Subject: Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2 In-Reply-To: <247ed79a-75c7-41fd-0932-0b7701ee5d4e@gmail.com> Message-ID: References: <247ed79a-75c7-41fd-0932-0b7701ee5d4e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Jun 2019, Michael Schmitz wrote: > Hi Finn, > > On 3/06/19 7:40 PM, Finn Thain wrote: > > > > > There are several other drivers that contain pieces of assembler code. > > > > > Does any driver contain assembler code for multiple architectures? I was > > trying to avoid that -- though admittedly I don't yet have actual code for > > the PDMA implementation for mac_scsi for Nubus PowerMacs. > > > I've seen that once, for one of the ESP drivers that were supported on both > m68k and ppc (APUS, PPC upgrade to Amiga computers). But that driver was > removed long ago (after 2.6?). > > In that case, the assembly file did reside in drivers/scsi/. That still > appears to be current practice (see drivers/scsi/arm/acornscsi-io.S). > The presence of that file would be an argument for adding drivers/scsi/m68k/. This seems to be begging the question. Since there's no clear policy, I'll combine the two files and avoid the question for now. -- > Cheers, > > ??? Michael > > >