From: Finn Thain <fthain@telegraphics.com.au>
To: Tianxianting <tian.xianting@h3c.com>
Cc: "kashyap.desai@broadcom.com" <kashyap.desai@broadcom.com>,
"sumit.saxena@broadcom.com" <sumit.saxena@broadcom.com>,
"shivasharan.srikanteshwara@broadcom.com"
<shivasharan.srikanteshwara@broadcom.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"megaraidlinux.pdl@broadcom.com" <megaraidlinux.pdl@broadcom.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: megaraid_sas: use spin_lock() in hard IRQ
Date: Fri, 23 Oct 2020 13:44:01 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.23.453.2010231324510.6@nippy.intranet> (raw)
In-Reply-To: <89c5cb05cb844939ae684db0077f675f@h3c.com>
On Thu, 22 Oct 2020, Tianxianting wrote:
> I see, If we add this patch, we need to get all cpu arch that support
> nested interrupts.
>
I was just calling into question 1. the benefit (does it improve
performance?) and 2. the code style (is it less portable?).
It's really the style question that mostly interests me because I've had
to code around the nested interrupt situation before, and everytime it
comes up it makes me wonder about the necessity.
I was not trying to veto your patch. It is not my position to do that. If
Broadcom likes the patch, that's great.
prev parent reply other threads:[~2020-10-23 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 6:45 Xianting Tian
2020-10-22 2:25 ` Finn Thain
2020-10-22 2:59 ` Tianxianting
2020-10-22 3:29 ` Finn Thain
2020-10-22 10:09 ` Tianxianting
2020-10-23 2:44 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.23.453.2010231324510.6@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tian.xianting@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®