From: James Morris <jmorris@namei.org>
To: Cordelia <cordsam@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] audit: Moved variable declaration to beginning of function
Date: Tue, 19 Aug 2008 08:23:12 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.1.10.0808190822350.24485@tundra.namei.org> (raw)
In-Reply-To: <48A9A73F.9060400@linux.vnet.ibm.com>
On Mon, 18 Aug 2008, Cordelia wrote:
> got rid of compilation warning:
> ISO C90 forbids mixed declarations and code
>
> Signed-off-by: Cordelia Sam <cordesam@gmail.com>
> ---
> kernel/auditsc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 972f8e6..59cedfb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
>
> static int audit_match_perm(struct audit_context *ctx, int mask)
> {
> + unsigned n;
> if (unlikely(!ctx))
> return 0;
>
> - unsigned n = ctx->major;
> + n = ctx->major;
> switch (audit_classify_syscall(ctx->arch, n)) {
> case 0: /* native */
> if ((mask & AUDIT_PERM_WRITE) &&
Reviewed-by: James Morris <jmorris@namei.org>
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2008-08-18 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 16:45 Cordelia
2008-08-18 22:23 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0808190822350.24485@tundra.namei.org \
--to=jmorris@namei.org \
--cc=cordsam@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®