From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: a.beregalov@gmail.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] CRED: Further fix execve error handling
Date: Thu, 21 Aug 2008 08:37:08 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.1.10.0808210833080.8202@tundra.namei.org> (raw)
In-Reply-To: <20080820135624.10583.99230.stgit@warthog.procyon.org.uk>
On Wed, 20 Aug 2008, David Howells wrote:
> Further fix [compat_]do_execve() error handling. free_bprm() will release the
> cred_exec_mutex, but only if bprm->cred is not NULL.
This seems quite ugly and error-prone, with a mutex_unlock() being called
from a helper function rather than the body of the function which locked
it.
How about moving the mutex_unlock() out of free_bprm() and into the
calling code ?
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2008-08-20 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 13:56 David Howells
2008-08-20 14:21 ` Alexander Beregalov
2008-08-20 16:33 ` Alan Cox
2008-08-20 15:07 ` David Howells
2008-08-20 22:37 ` James Morris [this message]
2008-08-21 12:43 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0808210833080.8202@tundra.namei.org \
--to=jmorris@namei.org \
--cc=a.beregalov@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®