From: James Morris <jmorris@namei.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, zohar@us.ibm.com,
dvelarde@us.ibm.com, safford@us.ibm.com
Subject: Re: [PATCH] TPM: update char dev BKL pushdown
Date: Sat, 23 Aug 2008 08:58:57 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.1.10.0808230858070.24779@tundra.namei.org> (raw)
In-Reply-To: <20080822161908.GA24791@us.ibm.com>
On Fri, 22 Aug 2008, Serge E. Hallyn wrote:
> Quoting Rajiv Andrade (srajiv@linux.vnet.ibm.com):
> > This patch removes the BKL calls from the TPM driver, which
> > were added in the overall misc-char-dev-BKL-pushdown.patch,
> > as they are not needed. Changed num_opens from an int to atomic_t.
> >
> > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> > Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
>
> Yes, this patch is good.
>
> It would also be good to rename num_opens. Note that it is always
> either 0 or 1, and indicates whether someone has opened the chip.
> So 'is_open' may make more sense.
And use atomic_set() instead of atomic_inc().
- James
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2008-08-22 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 16:04 Rajiv Andrade
2008-08-22 16:19 ` Serge E. Hallyn
2008-08-22 22:58 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.10.0808230858070.24779@tundra.namei.org \
--to=jmorris@namei.org \
--cc=dvelarde@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=safford@us.ibm.com \
--cc=serue@us.ibm.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®