From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758035AbZEEX0R (ORCPT ); Tue, 5 May 2009 19:26:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752579AbZEEX0A (ORCPT ); Tue, 5 May 2009 19:26:00 -0400 Received: from tundra.namei.org ([65.99.196.166]:54335 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbZEEXZ7 (ORCPT ); Tue, 5 May 2009 19:25:59 -0400 Date: Wed, 6 May 2009 09:25:59 +1000 (EST) From: James Morris To: Mimi Zohar cc: linux-kernel@vger.kernel.org, david safford Subject: Re: [PATCH] integrity: lsm audit rule matching fix In-Reply-To: Message-ID: References: <1241543568.6101.10.camel@dyn9002018117.watson.ibm.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 May 2009, James Morris wrote: > On Tue, 5 May 2009, Mimi Zohar wrote: > > > An audit subsystem change replaced AUDIT_EQUAL with Audit_equal. > > Update calls to security_filter_rule_init()/match() to reflect > > the change. > > > > Index: security-testing-2.6/security/integrity/ima/ima_policy.c > > =================================================================== > > --- security-testing-2.6.orig/security/integrity/ima/ima_policy.c > > +++ security-testing-2.6/security/integrity/ima/ima_policy.c > > @@ -96,7 +96,7 @@ static bool ima_match_rules(struct ima_m > > if ((rule->flags & IMA_UID) && rule->uid != tsk->cred->uid) > > return false; > > for (i = 0; i < MAX_LSM_RULES; i++) { > > - int rc; > > + int rc = 0; > Also, please add a Signed-off-by. -- James Morris