From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752947AbZHEW7u (ORCPT ); Wed, 5 Aug 2009 18:59:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752171AbZHEW7u (ORCPT ); Wed, 5 Aug 2009 18:59:50 -0400 Received: from tundra.namei.org ([65.99.196.166]:41915 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbZHEW7t (ORCPT ); Wed, 5 Aug 2009 18:59:49 -0400 Date: Thu, 6 Aug 2009 08:59:25 +1000 (EST) From: James Morris To: David Howells cc: torvalds@osdl.org, Andrew Morton , "Serge E. Hallyn" , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, "Serge E. Hallyn" Subject: Re: [PATCH 5/6] KEYS: Make /proc/keys use keyid not numread as file position [ver #2] In-Reply-To: <20090804203943.25094.68091.stgit@warthog.procyon.org.uk> Message-ID: References: <20090804203923.25094.78702.stgit@warthog.procyon.org.uk> <20090804203943.25094.68091.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Aug 2009, David Howells wrote: > From: Serge E. Hallyn > > Make the file position maintained by /proc/keys represent the ID of the key > just read rather than the number of keys read. This should make it faster to > perform a lookup as we don't have to scan the key ID tree from the beginning to > find the current position. > > Signed-off-by: Serge E. Hallyn > Signed-off-by: David Howells This does not apply to my tree: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next Looks like it's due to pending changes in the same file. Could you please generate this patch against my tree? - James -- James Morris