From: James Morris <jmorris@namei.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-security-module@vger.kernel.org, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCH] KEYS: Reinstate lost passing of process keyring ID in call_sbin_request_key()
Date: Thu, 1 Jul 2010 10:19:24 +1000 (EST) [thread overview]
Message-ID: <alpine.LRH.2.00.1007011019060.23781@tundra.namei.org> (raw)
In-Reply-To: <20100630093911.28103.73746.stgit@warthog.procyon.org.uk>
On Wed, 30 Jun 2010, David Howells wrote:
> From: Justin P. Mattock <justinmattock@gmail.com>
>
> In commit bb952bb98a7e479262c7eb25d5592545a3af147d there was the accidental
> deletion of a statement from call_sbin_request_key() to render the process
> keyring ID to a text string so that it can be passed to /sbin/request-key.
>
> With gcc 4.6.0 this causes the following warning:
>
> CC security/keys/request_key.o
> security/keys/request_key.c: In function 'call_sbin_request_key':
> security/keys/request_key.c:102:15: warning: variable 'prkey' set but not used
>
> This patch reinstates that statement.
>
> Without this statement, /sbin/request-key will get some random rubbish from the
> stack as that parameter.
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2010-07-01 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277861297-13824-1-git-send-email-justinmattock@gmail.com>
2010-06-30 9:39 ` David Howells
2010-07-01 0:19 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.00.1007011019060.23781@tundra.namei.org \
--to=jmorris@namei.org \
--cc=dhowells@redhat.com \
--cc=justinmattock@gmail.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®